Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated unit tests from arrays #1408

Closed
wants to merge 1 commit into from
Closed

Remove outdated unit tests from arrays #1408

wants to merge 1 commit into from

Conversation

Kexanone
Copy link
Contributor

@Kexanone Kexanone commented Jan 16, 2021

When merged this pull request will:

  • Remove unit tests in arrays component that pass invalide arguments.

@commy2
Copy link
Contributor

commy2 commented Jan 16, 2021

None of these are outdated though. They also all pass, except x\cba\addons\arrays\test_shuffle.sqf:26, though I can't make out why that expects the count to be 1 either. Just ignore.

This pull request should be closed.

@Kexanone
Copy link
Contributor Author

None of these are outdated though. They also all pass, except x\cba\addons\arrays\test_shuffle.sqf:26, though I can't make out why that expects the count to be 1 either. Just ignore.

This pull request should be closed.

My bad. You are right, it's only that x\cba\addons\arrays\test_shuffle.sqf:26 that breaks the test. The wrong argument types only show a script error, but pass the test.

@Kexanone Kexanone closed this Jan 16, 2021
@Kexanone Kexanone deleted the fix-arrays-test branch January 16, 2021 21:12
@commy2
Copy link
Contributor

commy2 commented Jan 16, 2021

Yeah, sanity is checked even when script errors are raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants