Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEH - Fix missing XEH on AoW objects (2.02) #1420

Merged
merged 2 commits into from
Feb 24, 2021
Merged

XEH - Fix missing XEH on AoW objects (2.02) #1420

merged 2 commits into from
Feb 24, 2021

Conversation

PabstMirror
Copy link
Contributor

No description provided.

@commy2
Copy link
Contributor

commy2 commented Feb 11, 2021

GalleryDioramaUnit

Huh?

// AOW (2.02)
class GalleryDioramaUnit_01_base_F: Items_base_F {
XEH_ENABLED;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not necessarily require 2.02, but I guess it is a good thing to update this anyway? Would merge the PR now if the requirement was not set.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is based on current RC and sometimes things change, so we shouldn't merge until 2.02 is officially released

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still needed in release

@PabstMirror PabstMirror added this to the Ongoing milestone Feb 13, 2021
@PabstMirror PabstMirror modified the milestones: Ongoing, 3.15.3 Feb 20, 2021
@commy2 commy2 merged commit 7f369a7 into master Feb 24, 2021
@commy2 commy2 deleted the aowXEH branch February 24, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants