Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEH - Fix missing XEH on GM objects #1426

Merged
merged 1 commit into from
Feb 24, 2021
Merged

XEH - Fix missing XEH on GM objects #1426

merged 1 commit into from
Feb 24, 2021

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Feb 24, 2021

When merged this pull request will:

  • fixes XEH on some GM objects
  • close XEH - GM has two classes that don't support XEH #1365
  • I didn't test this. Please test this. You don't have to check if XEH works, just start with GM on any mission and check if any error messages pop up and if the mentioned error messages correctly disappear.

@commy2 commy2 added the Bug Fix label Feb 24, 2021
@commy2 commy2 added this to the 3.15.3 milestone Feb 24, 2021
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with the compat mod, which I think has the same configs

@Cyruz143
Copy link

Built and tested on full GM version, no XEH errors


12:23:43 [CBA] (xeh) INFO: [20077,81.881,0] PostInit started. MISSIONINIT: missionName=tempMissionSP, missionVersion=54, worldName=Altis, isMultiplayer=false, isServer=true, isDedicated=false, CBA_isHeadlessClient=false, hasInterface=true, didJIP=false
12:23:43 [CBA] (xeh) INFO: [20077,82.723,0] PostInit finished.

@commy2 commy2 merged commit bc27e42 into master Feb 24, 2021
@commy2 commy2 deleted the fix-gm-xeh branch February 24, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XEH - GM has two classes that don't support XEH
3 participants