Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 New Array Functions #143

Merged
merged 7 commits into from
Sep 6, 2015
Merged

Add 2 New Array Functions #143

merged 7 commits into from
Sep 6, 2015

Conversation

jokoho48
Copy link
Member

add getHightestVaule
add getLowestVaule

add getLowestVaule
@@ -27,6 +27,18 @@ class CfgFunctions
description = "A function used to return the element counts in an array. Parameters: Array Example: _types = [0,0,1,1,1,1] call CBA_fnc_getArrayElements Returns: Array element counts (for above example, return would be [0,2,1,4]) Author: Rommel && sbsmac";
file = "\x\cba\addons\arrays\fnc_getArrayElements.sqf";
};
// CBA_fnc_getHightestVaule
class getHightestVaule
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be getHighestValue, check spelling (not just here).

@Killswitch00
Copy link
Contributor

These functions could have much shorter names:

  • CBA_fnc_findMin
  • CBA_fnc_findMax

MikeMatrix and others added 2 commits August 30, 2015 17:23
…d error handling, small logic fixes and added tests
General update to findMin and findMax
(end)

Returns:
_max: smallest value in array
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"_min"

Improve exit Condition
@jokoho48
Copy link
Member Author

ok done

// CBA_fnc_findMax
class findMax
{
description = "Find smallest numeric value with index in an array.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the description for findMin below.

@Killswitch00
Copy link
Contributor

The merge conflicts in addons/arrays/test.sqf and addons/arrays/CfgFunctions.hpp need to be fixed.

Conflicts:
	addons/arrays/CfgFunctions.hpp
	addons/arrays/test.sqf
@jokoho48
Copy link
Member Author

jokoho48 commented Sep 6, 2015

ok fixed

Killswitch00 added a commit that referenced this pull request Sep 6, 2015
@Killswitch00 Killswitch00 merged commit a7fd6d8 into CBATeam:master Sep 6, 2015
@jokoho48 jokoho48 deleted the addNewArrayFunctions branch September 6, 2015 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants