Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use execVM for all unit tests #1453

Merged
merged 1 commit into from
May 17, 2021
Merged

Use execVM for all unit tests #1453

merged 1 commit into from
May 17, 2021

Conversation

Dahlgren
Copy link
Contributor

@Dahlgren Dahlgren commented May 10, 2021 •
edited
Loading

When merged this pull request will:

  • Run as unit tests with execVM instead of call
execVM "\x\cba\addons\main\test.sqf"

557 Test OK
1 Test FAIL

@commy2
Copy link
Contributor

commy2 commented May 10, 2021

You can remove the nil's while at it. waitUntil has no rv.

@commy2
Copy link
Contributor

commy2 commented May 10, 2021

Looks pretty good.

Except that there is a short hand for

0 spawn compile preprocessFileLineNumbers

which is the dreaded execVM. :)

@jonpas jonpas added this to the 3.15.4 milestone May 10, 2021
@Dahlgren Dahlgren changed the title Use spawn for all unit tests Use execVM for all unit tests May 10, 2021
@commy2 commy2 merged commit 72d5c2a into CBATeam:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commy2 commy2 commy2 approved these changes

@Killswitch00 Killswitch00 Killswitch00 approved these changes

Assignees
No one assigned
Labels
Enhancement Tools
Projects
None yet
Milestone
3.15.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dahlgren @commy2 @Killswitch00 @jonpas