Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate settings into a single category #1464

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Consolidate settings into a single category #1464

merged 1 commit into from
Jun 11, 2021

Conversation

mharis001
Copy link
Contributor

When merged this pull request will:

  • Consolidate the 8 settings currently added by CBA itself into a single category separated into subcategories
  • For consistency, make all setting display names title case
Image

cba_settings_3

@PabstMirror PabstMirror added this to the 3.15.4 milestone Jun 10, 2021
@commy2
Copy link
Contributor

commy2 commented Jun 11, 2021

Where are these translations from?

@mharis001
Copy link
Contributor Author

CBA and ACE. Removed the prefix/suffix from existing entries and got the "User Interface" string directly from ace_ui.

@PabstMirror PabstMirror merged commit deb411b into CBATeam:master Jun 11, 2021
@mharis001 mharis001 deleted the settings-organization branch June 11, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commy2 commy2 commy2 approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
Cleanup
Projects
None yet
Milestone
3.15.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mharis001 @commy2 @PabstMirror