Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New function: prettyFormat #1519

Closed
wants to merge 23 commits into from
Closed

New function: prettyFormat #1519

wants to merge 23 commits into from

Conversation

7erra
Copy link
Contributor

@7erra 7erra commented Nov 8, 2021 •
edited
Loading

When merged this pull request will:

  • Add the prettyFormat function to CBA's functions library

@commy2

This comment has been minimized.

Sign in to view
@commy2

This comment has been minimized.

Sign in to view
Dystopian
Dystopian reviewed Nov 9, 2021
View reviewed changes
addons/arrays/fnc_prettyPrint.sqf Outdated Show resolved Hide resolved
addons/arrays/fnc_prettyPrint.sqf Outdated Show resolved Hide resolved
addons/arrays/fnc_prettyPrint.sqf Outdated Show resolved Hide resolved
addons/arrays/fnc_prettyPrint.sqf Outdated Show resolved Hide resolved
@7erra 7erra changed the title New function: prettyPrint New function: prettyFormat Nov 9, 2021
Dystopian
Dystopian reviewed Nov 9, 2021
View reviewed changes
addons/arrays/fnc_prettyFormat.sqf Outdated Show resolved Hide resolved
addons/arrays/fnc_prettyFormat.sqf Outdated Show resolved Hide resolved
addons/arrays/fnc_prettyFormat.sqf Outdated Show resolved Hide resolved
@7erra @Dystopian
Removed unnecessary brackets
ca2f35d 
Co-authored-by: Dystopian <sddex@ya.ru>
@7erra @commy2
Removed ";" from returned values
590ba03 
Co-authored-by: commy2 <commy-2@gmx.de>
@commy2
Copy link
Contributor

commy2 commented Nov 11, 2021

lgtm
Setting up _tabs every layer seems not very elegant though.
Needs unit test.

@7erra
Copy link
Contributor Author

7erra commented Nov 11, 2021 •
edited
Loading

Another idea is to add an option to set what linebreak char to use. currently it is endl but it would be useful to also allow <br/> for structured text.

@commy2
Copy link
Contributor

commy2 commented Nov 11, 2021

Or "\n" for hint, although I think endl should work there too?

7erra and others added 2 commits November 11, 2021 20:37
@7erra @commy2
Fix linter
d82918f 
Co-authored-by: commy2 <commy-2@gmx.de>
@7erra
Added parameter for line break char
3b58529
@commy2
Copy link
Contributor

commy2 commented Nov 11, 2021

Should default indent really be tab? Seems unusual for Arma/SQF.

@commy2
Copy link
Contributor

commy2 commented Nov 11, 2021

That said _tabs -> _indents

@commy2 commy2 mentioned this pull request Nov 12, 2021
Merged
@jonpas jonpas closed this in #1522 Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dystopian Dystopian Dystopian left review comments

@commy2 commy2 commy2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@7erra @commy2 @Dystopian