Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostic - Optimize target watch variable broadcast #1520

Merged
merged 6 commits into from
Nov 11, 2021
Merged

Diagnostic - Optimize target watch variable broadcast #1520

merged 6 commits into from
Nov 11, 2021

Conversation

shukari
Copy link
Contributor

@shukari shukari commented Nov 10, 2021 •
edited
Loading

When merged this pull request will:

@shukari @commy2
Update addons/diagnostic/stringtable.xml
63fad66 
Co-authored-by: commy2 <commy-2@gmx.de>
commy2
commy2 approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, maybe pabst double check

PabstMirror
PabstMirror approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PabstMirror
Copy link
Contributor

imho target debugging was really designed more for development and not "in-production"
but if it's getting used this way, there's no reason not to make it better

@commy2 commy2 merged commit 1f780ae into CBATeam:master Nov 11, 2021
@PabstMirror PabstMirror added this to the 3.15.7 milestone Nov 11, 2021
@jonpas jonpas changed the title diagnostic - target watch variable is broadcasted to all Diagnostic - Optimize target watch variable broadcast Nov 11, 2021
@shukari shukari deleted the patch-2 branch November 11, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commy2 commy2 commy2 approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
3.15.7
Development

Successfully merging this pull request may close these issues.

Optimize CBA_targetWatch
3 participants
@shukari @PabstMirror @commy2