Settings - Add "volatile" option to not persist server settings after restart #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veteran29
changed the title
veteran29
changed the title
|
|
BrettMayson
requested changes
Oct 15, 2023
Co-authored-by: BrettMayson <brett@mayson.io>
BrettMayson
approved these changes
Oct 16, 2023
PabstMirror
reviewed
Oct 16, 2023
PabstMirror
reviewed
Oct 16, 2023
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
PabstMirror
approved these changes
Oct 17, 2023
PabstMirror
previously requested changes
Oct 17, 2023
There was a problem hiding this comment.
actually this breaks load/save
Documents\Arma 3 - Other Profiles\Pabst%20Mirror\UserSaved\missions\testSave.Stratis\save.Arma3Save/GameState/Item2724/data.: Value type not matching: Namespace != Nothing
Error loading/saving variable cba_settings_serverhashnamespace
Error 'Bad file structure' at 'Documents\Arma 3 - Other Profiles\Pabst%20Mirror\UserSaved\missions\testSave.Stratis\save.Arma3Save/GameState/Item2724/data.'.
ErrorMessage: Cannot load 'Documents\Arma 3 - Other Profiles\Pabst%20Mirror\UserSaved\missions\testSave.Stratis\save.Arma3Save'.
Application terminated intentionally
ErrorMessage: Cannot load 'Documents\Arma 3 - Other Profiles\Pabst%20Mirror\UserSaved\missions\testSave.Stratis\save.Arma3Save'.
PabstMirror
reviewed
Oct 17, 2023
PabstMirror
reviewed
Oct 17, 2023
veteran29
force-pushed
the
settings-do-not-store-in-profile
branch
from
e336585
to
87d40e9
Compare
veteran29
commented
Oct 17, 2023
|
Crashes fixed by not storing namespaces in variables. |
PabstMirror
approved these changes
Oct 21, 2023
jonpas
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
cba_settings_volatileroot config property1it will load/store server settings fromuiNamespaceinstead ofprofileNamespaceeffectively making them persist only to the game restart