Configs - Cleanup for hemtt macro padding check #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
commented
Oct 28, 2023
| @@ -1,3 +1,6 @@ | |||
| #pragma hemtt suppress pw3_padded_arg file | |||
| #pragma hemtt suppress pw3_padded_arg config | |||
|
|
|||
There was a problem hiding this comment.
@BrettMayson - still getting with either/both line, not sure if error or just how the includes work
[PW3] Warning: padding a macro argument
╭─[/a3/ui_f/hpp/defineDIKCodes.inc:119:36]
│
119 │ #define DIK_NUMPADENTER 0x9C /* Enter on numeric keypad */
│ ┬
│ ╰── padding a macro argument is likely unintended
There was a problem hiding this comment.
It's might be where DIK_NUMPADENTER is being used, and the error is just pointing to the wrong location. The comment will be removed, but the padded whitespace won't
There was a problem hiding this comment.
yeah, it's on use not on define
which is actually good because it means we don't have to touch the bi files
a nice-to-have would be to indicate usage location
|
Building with no warnings for hemtt 1.10 |
jonpas
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not touching flexi-menu