Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Improve support of pictures in mission list filter #1651

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

veteran29
Copy link
Member

@veteran29 veteran29 commented Mar 26, 2024

When merged this pull request will:

  • title

Reaction Forces Creator DLC adds DLC pictures to mission lists, this will save and restore them during the filtering. Right picture is not used by anything but won't hurt to save/restore it in case some mod does.

Vanilla:
image

Reaction Forces:
image

@veteran29 veteran29 marked this pull request as draft March 26, 2024 16:52
@veteran29
Copy link
Member Author

It still removes the icons when you toggle between stock/custom missions but shows them properly when loading the display and change the worlds. I guess won't hurt to merge and possibly improve later?

@veteran29 veteran29 changed the title UI - Support pictures in mission list filter UI - Improve support of pictures in mission list filter Mar 26, 2024
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes it halfway, so better than nothing. Undraft it and merge.

@jonpas jonpas added this to the 3.16.2 milestone Mar 28, 2024
@jonpas jonpas marked this pull request as ready for review March 28, 2024 19:29
@jonpas jonpas merged commit 1db1838 into master Mar 28, 2024
4 checks passed
@jonpas jonpas deleted the mission-list-picture-support branch March 28, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants