Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disposables - Fix check if floating point mass are roughly the same #1682

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Disposables - Fix check if floating point mass are roughly the same #1682

merged 2 commits into from
Sep 21, 2024

Conversation

PabstMirror
Copy link
Contributor 

Sum of mass of launcher PSZ_RPG76_Base and mass of magazine PSZ_PG76_HEAT (7.04+39.16=46.2) 
is different from mass of loaded launcher PSZ_RPG76 (46.19).

Their numbers are still off by a hundredth
but the diff comes out to 0.0100021 because of floating point

@PabstMirror PabstMirror added this to the 3.18.0 milestone Aug 11, 2024
veteran29
veteran29 approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PabstMirror PabstMirror merged commit 543b57c into master Sep 21, 2024
4 checks passed
@PabstMirror PabstMirror deleted the disFloats branch September 21, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrettMayson BrettMayson BrettMayson approved these changes

@veteran29 veteran29 veteran29 approved these changes

@johnb432 johnb432 johnb432 approved these changes

Assignees
No one assigned
Labels
Ignore Changelog
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@PabstMirror @BrettMayson @veteran29 @johnb432