Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help - Sort addons, credits and keybindings alphabetically #1684

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title.
  • Fixes mods such as O&T Expansion Eden breaking the Addons diary entry, because of the & not being sanitised.
  • I haven't tested if this works with keybinds that are added via config - I don't know of any mods that use that.

@PabstMirror PabstMirror added this to the 3.18.0 milestone Aug 20, 2024
@PabstMirror
Copy link
Contributor

config keybinds look great (there are some demo on https://github.com/CBATeam/CBA_A3/blob/master/addons/events/config.cpp#L51)

image

they are a little strange in that you still need to add them via code
(and the keybind still shows if you don't, but that's how it worked before)

@PabstMirror PabstMirror merged commit 105fcc2 into CBATeam:master Aug 26, 2024
4 checks passed
@johnb432 johnb432 deleted the help-improve-diaries branch August 26, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants