Fix RPT issue in PFH main Loop #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,7 +26,9 @@ Author: | |||
|
|
|||
| params ["_publicHandle"]; | |||
| private "_handle"; | |||
| if (isNil "_publicHandle" || (_publicHandle < 0)) exitWith {}; // Nil/no handle, nil action | |||
| if ((isNil "_publicHandle" || (_publicHandle < 0)) && {(count GVAR(PFHhandles)) < _publicHandle}) exitWith { // Nil/no handle, nil action or handle is larger than Public Handle Array | |||
| WARNING("PFH ID allready Removed or handle Not Exist or handle is smaller than 0"); | |||
There was a problem hiding this comment.
PFH ID already removed or handle does not exist or handle is smaller than 0
There was a problem hiding this comment.
I'd go with Invalid or not existing PFH ID.
|
ok i and @jonpas tested it no issues found |
|
👍 |
ViperMaul
added a commit
that referenced
this pull request
Oct 10, 2015
fix RTP issue in PFH main Loop
| @@ -25,8 +25,12 @@ Author: | |||
| #include "script_component.hpp" | |||
|
|
|||
| params ["_publicHandle"]; | |||
|
|
|||
| if (isNil "_publicHandle" || {(_publicHandle < 0)} || {!((count GVAR(PFHhandles)) >= _publicHandle)}) exitWith { // Nil/no handle, nil action or handle is larger than Public Handle Array | |||
There was a problem hiding this comment.
Should this be {(count GVAR(PFHhandles) <= _publicHandle)}?
If the count is 0, and the _publicHandle is 0, you want it to be true and exit.
|
@PabstMirror @jokoho48 |
ViperMaul
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.