-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added team color synchronization #185
Changes from 6 commits
511540e
6e94057
9fede0a
d57b1cc
f44bbe3
5a396cc
2210b67
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/* ---------------------------------------------------------------------------- | ||
Internal Function: CBA_fnc_onTeamColorChanged | ||
|
||
Description: | ||
Assigns the units team color if it changed on another machine. | ||
|
||
Parameters: | ||
_unit - unit [OBJECT] | ||
_team - team the unit got assigned to [STRING] | ||
|
||
Returns: | ||
Nothing | ||
|
||
Author: | ||
BaerMitUmlaut | ||
---------------------------------------------------------------------------- */ | ||
|
||
#include "script_component.hpp" | ||
params ["_unit", "_team"]; | ||
|
||
_unit assignTeam _team; | ||
if (local (leader _unit)) then { | ||
_unit setVariable [QGVAR(synchedTeam), _team, true]; | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/* ---------------------------------------------------------------------------- | ||
Internal Function: CBA_fnc_synchTeamColors | ||
|
||
Description: | ||
Synchs the team colors every second. Does not need to be called manually. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is no time delay in this function, but rather in the PFH calling this function. I'd remove the |
||
|
||
Parameters: | ||
None | ||
|
||
Returns: | ||
Nothing | ||
|
||
Author: | ||
BaerMitUmlaut | ||
---------------------------------------------------------------------------- */ | ||
|
||
#include "script_component.hpp" | ||
|
||
if (leader player == player) then { | ||
{ | ||
if ((assignedTeam _x) != (_x getVariable [QGVAR(synchedTeam), "MAIN"])) then { | ||
//Local team != currently synched team, so we need to synchronize them again | ||
["CBA_teamColorChanged", [_x, assignedTeam _x]] call CBA_fnc_globalEvent; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, in case another player joins the squad he needs to know the assigned colors as well. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't that mean you want to sync them up upon joining the team instead? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's possible too, but would require extension of the PFH (unless there's a CBA event for it? there's no doc for default events and I didn't see any either) and it would ofc have a delay. Without that delay it would be great for triggering a CBA event though. Either options aren't perfect in my opinion. Choose your poison... |
||
}; | ||
true | ||
} count units player; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only if it changed on the
leaders
machine?