Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missionConfig problem in 1.55 dev #199

Merged
merged 2 commits into from
Nov 21, 2015

Conversation

PabstMirror
Copy link
Contributor

Fix #198

-make SLX_XEH_CONFIG_FILES a macro
edit - I guess something else could write to this array?? (like another place to put XEH configs?) This seems unlikely but possible.
-use new getMissionConfig command

Also fix a problem where the description.ext respawn capitalization had an effect.

make SLX_XEH_CONFIG_FILES a macro
use new getMissionConfig command
@Killswitch00
Copy link
Contributor

The _respawn part could be refactored to use getMissionConfigValue

@PabstMirror
Copy link
Contributor Author

getMissionConfig / getMissionConfigValue are still things we can look at, but they aren't needed to fix the crash, and they are not in 1.54RC.

The changes made here should allow a CBA that is compatible with both 1.54 and dev branch.

Killswitch00 added a commit that referenced this pull request Nov 21, 2015
Handle missionConfig problem in 1.55 dev
@Killswitch00 Killswitch00 merged commit 05f9b4b into local_keyword_fixes Nov 21, 2015
@PabstMirror PabstMirror deleted the fix155missionConfigCrash branch November 30, 2015 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants