-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show when a keybind is unbound #205
Conversation
@@ -106,6 +106,12 @@ if !(isNull _display) then { | |||
}; | |||
}; | |||
|
|||
private _isUnbound = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't work for 1.52
I can not reproduce the problem that this PR supposedly solves. An action for which the assigned key is unbound (deleted) is shown as...well, nothing in the "Assigned keys" column in the configuration dialog. |
@Killswitch00 If there is only one key unbound in the category it will show up empty (this is fine), but due to empty actually being it's own "key" it will show up as a duplicate bind when having more empty binds. |
Thanks for the explanation and screenshot. |
👍 |
As mentioned elsewhere, how about displaying unbound keys as they are displayed in the normal game key assingment dialog, ie with the assigned key field empty? (As PabstMirror said, it would save us the trouble of translating the [UNBOUND] string) |
Fix private and mark dikCode -1 or 0 as unbound Just show blank space for unbound keys Formatting
d95f32d
to
9b512ee
Compare
Show when a keybind is unbound
Before it would show all unbound keys as duplicates (red)