Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JR: Do not blacklist long scopes on the short mg rails anymore, move … #246

Merged

Conversation

robalo
Copy link
Contributor

@robalo robalo commented Jan 22, 2016

…that to optional pbo instead. Fixes #159.

@commy2
Copy link
Contributor

commy2 commented Jan 23, 2016

Works 👍 Only problem is that these attachments are still shown in the arsenal, but are not useable (at least in current 1.55 dev).
I think that is a problem of the VA though.
http://i.imgur.com/B6kyqH2.jpg

@Killswitch00
Copy link
Contributor

commy2, does the same no-usability issue happen if you start 1.55dev without CBA? If not, it is worth investigating further.

@robalo
Copy link
Contributor Author

robalo commented Jan 23, 2016

That behavior would be when the scope is incompatible (will happen with the optional pbo) and it's indeed a problem in VA which does not filter compatible items properly: http://feedback.arma3.com/view.php?id=23111

@Killswitch00
Copy link
Contributor

Ah, OK - "good" news (read: it's not CBA)

Killswitch00 added a commit that referenced this pull request Jan 23, 2016
JR: Do not blacklist long scopes on the short mg rails anymore, move …
@Killswitch00 Killswitch00 merged commit dbc5e25 into fn_compat_items_private_oneliners Jan 23, 2016
@Killswitch00
Copy link
Contributor

Hmm...that did not go where it should...

@robalo
Copy link
Contributor Author

robalo commented Jan 23, 2016

Might be my bad, did PR from diff between 2 of my branches.

@ViperMaul ViperMaul added this to the 2.3 milestone Jan 28, 2016
@thojkooi thojkooi deleted the jr_vanilla_mg_scopes_fix branch April 25, 2016 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants