Add Caching to CBA_fnc_compatibleItems (Cleanup)

[PabstMirror]

Added fixes and test case to @jokoho48 's #261

[jokoho48]

from my side this is good to go 👍 but @robalo is the maintainer

[robalo]

I have to catch up with things, don't wait for me. as long as you don't break the function... go for it.
If this will be called for a lot of weapons, should we be concerned about polluting the namespace with a lot of variables ?

[nicolasbadano]

should we be concerned about polluting the namespace with a lot of variables ?

No, don't worry. This PR stores the cache on a dedicated namespace (location).

[Killswitch00]

"Caching added by..."

[jokoho48]

:D ok will fix it

[Killswitch00]

configProperties, isClass

[commy2]

This has one drawback. createLocation crashes the game when no mission is there. Really minor, but we don't know all the ways this function could be used.

[Killswitch00]

Crashing the game doesn't sound minor to me. Please elaborate on "when no mission is there" and when/how the crash happens. (Potential for MP abuse?)

[commy2]

For example when it's used in the main menu with -world="empty" or in a CfgFunctions with preStart = 1;
I really really doubt any addon out there does that, but if there would be, it would crash after this PR.
No MP abuse here.

[PabstMirror]

Could leave first function untouched and add a 2nd that does caching.
or if (missionName == "") exitWith {[]};

[commy2]

That might work, but again. This issue will most likely never happen.

[commy2]

I was wrong about the crash in the main menu. Can't reproduce anymore. This PR should work.

[Killswitch00]

Fix the comments so we can merge this.