Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a designated CBA_Extended_EventHandlers base class #294

Merged
merged 1 commit into from
Mar 6, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Mar 5, 2016

This is an issue @bux encountered when trying to reenable XEH on some static / building objects.
Usually those have XEH disabled, which is done by clearing the CBA_Extended_EventHandlers.

When setting up inheritance of the EventHandlers class, you actually carry over the references to all sub classes defined in that class.

http://i.imgur.com/wgAVHKI.jpg

SignAd_Sponsor 's EventHandlers is from Thing. Thing has an empty CBA_Extended_EventHandlers class to disable XEH on random map objects.
But bux was trying to inherit the actual root class which is also called CBA_Extended_EventHandlers and since Arma can only reference base classes by their name, the empty one from Thing was selected instead of the full one on root config.
The only work around currently is to discard the EventHandlers class, which is not ideal.

This can be avoided by adding a differently named base class. CBA_Extended_EventHandlers_base. CBA_Extended_EventHandlers has to stay for backwards compatibility...

Killswitch00 added a commit that referenced this pull request Mar 6, 2016
add a designated CBA_Extended_EventHandlers base class
@Killswitch00 Killswitch00 merged commit d1042f4 into master Mar 6, 2016
@thojkooi thojkooi deleted the xehbaseclass branch April 25, 2016 11:33
@commy2 commy2 added this to the 2.3.2 milestone May 15, 2016
@commy2 commy2 mentioned this pull request Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants