use mission event for PlayerConnected #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is missing the WIP label |
|
PlayerConnected is still broken. I could add a work around that could be easily removed should they ever fix it. |
commy2
changed the title
|
could be merged now. maybe we can remove that band aid ... eventually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this replaces all
onPlayerConnectedstacked events withPlayerConnectedmission events. it has the benefit that no mission or addon using a delayedonPlayerConnected <CODE>(SQF command) can overwrite our events.WIP tag, because there currently is a bug, where the
PlayerConnectedmission event does not fire whenonPlayerConnected <CODE>hasn't been used at least once. this is fixed according to the todays changelog, but the bug seems to be still present in the RC version uploaded to Steam.I'll test if they fixed that next week.
backwards compatible with 1.54 / Linux, using the same method as in the
EachFramePR