add 'CBA_fnc_addPlayerEventHandler'

[commy2]

Port (?) from ACE.
This is a framework to add event handlers based around properties of the players avatar that are pretty usefull, but unfortunately require polling.

Possible events:
- "unit" - player controlled unit changed
- "weapon" - currently selected weapon change
- "loadout" - players loadout changed
- "vehicle" - players current vehicle changed
- "turret" - position in vehicle changed
- "visionMode" - player changed to normal/night/thermal view
- "cameraView" - camera mode changed ("Internal", "External", "Gunner" etc.)
- "visibleMap" - opened or closed map

[nicolasbadano]

Mmm, I celebrate that these are getting added to CBA. However, I'm not really fond of the way it's executed for two reasons:

1- Most of the events are trivially cheap to evaluate, but instead of adding them to a single loop that always run (like in ACE), each one is tucked in it's own EH function, making them slower. This is specially true if you want to use many or all of them (like in ACE). I would instead recommend that either all of them are installed by default, or all are installed when the first is.

2- That a new installer function is required CBA_fnc_addPlayerEventHandler instead of CBA_fnc_addLocalEvent

[commy2]

All checks could certainly be moved in one EachFrame event.

I don't want to have this loop running by default though. Most mods won't make use of any of these, so I want to avoid being critiqued for adding 'pointless' checks every frame. Imagine a community using CBA only for JR and CUP (Life + CUP) or even a mil sim comm with only CBA + TFAR.
A wrapper would still be needed in that case and I don't really see a problem with that.

[bux]

How about running everything in one loop and have developers "opt-in" to the events?

[PabstMirror]

We could dynamically build up the polling function with compile.

[commy2]

How about running everything in one loop and have developers "opt-in" to the events?

Using the CBA_fnc_addPlayerEventHandler function once would be a way to opt-in I guess.

We could dynamically build up the polling function with compile.

Sure. That would mean compiling 8 functions at mission start though (because if you use all, they are all added after another)

I kinda like CBA_fnc_addPlayerEventHandler, because it gives these events context without having to name them playerInventoryChanged, playerWeaponChanged, ... Instead they can be called inventory, weapon etc.

[nicolasbadano]

Thanks @commy2 👍

[Killswitch00]

Either shorten to one sentence or separate with empty line for possible future improvements to documentation generation.