Replace replace

[BaerMitUmlaut]

This PR replaces the replace function. The old one does not work properly with some characters (for example öüäß) due to buggy BI commands:

("ü" splitString "") apply {toArray _x}
-> [[65533],[65533]]
"abcßdef" find "ß"
-> 3
"abcßdef" find "d"
-> 5

It also adds params checking and doesn't use any toArray/toString stuff anymore.

[commy2]

This is not needed. ...?

[BaerMitUmlaut]

This checks for infinite loops when you would do something like:

["Hello", "e", "ee"] call CBA_fnc_replace;

[commy2]

Before:

["TEST","E","EA"] call CBA_fnc_replace
"TEAST"

After:

["TEST","E","EA"] call CBA_fnc_replace
"TEST"

[BaerMitUmlaut]

This works now:

["TEST","E","EA"] call CBA_fnc_replace
-> "TEAST"

[commy2]

Passes the test now

0 spawn compile preprocessFileLineNumbers  "\x\cba\addons\strings\test_strings.sqf"

The benefit of this PR:
Before:

["Mörser","ö","oe"] call CBA_fnc_replace
-> "Moeser"

After:

["Mörser","ö","oe"] call CBA_fnc_replace
-> "Moerser"

We should probably add that and "TEAST" to the test.

[commy2]

Performance:
["Mörser","ö","oe"] call CBA_fnc_replace

Before: 0.0525 ms
After: 0.0432 ms

[Killswitch00]

Agree - please add the two new tests to the unit test suite.

[BaerMitUmlaut]

Those two tests have been added.