-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sending events to client IDs #340
Conversation
Would this be better if incorporated into |
This has one problem. To solve this, I suggest the server publicVariableClient'ing the actual client id from a |
Now syncs clientID, probably needed to do anyway because |
if (_owner != 2) then { | ||
GVAR(clientID) = _owner; | ||
_owner publicVariableClient QGVAR(clientID); | ||
GVAR(clientID) = [0, 2] select isMultiplayer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable seems useful. Maybe name it "CBA_clientID" thereby make it "official" API, just like CBA_missionTime
?
TRACE_5("PlayerConnected eh",_id,_uid,_name,_jip,_owner); | ||
|
||
if (_owner != 2) then { | ||
CBA_clientID = _owner; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are PlayerConnected
handlers executed in scheduled or unscheduled space? (If scheduled, I see a race condition with the CBA_clientID
variable here)
I am still wondering why that's not incorporated into |
Merge reverted - discussion on this PR had not finished yet. PabstMirror, please re-submit the function for further discussion. |
No description provided.