Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch help framework to 'authorS', remove all author[] #345

Merged
merged 4 commits into from
Jun 1, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented May 31, 2016

  • changes CBA Help framework to use new BI author entry. (while filtering out all BI classes)
  • to keep functionality of having multiple authors per PBO, add optional authors[] entry.
  • add standardized STR_CBA_Author string as author to all CBA PBOs.

This will not fix the No Entry blah/author error pop ups of other mods. Either BI fixes the game or every mod author has to adjust.

@commy2 commy2 added the Bug Fix label May 31, 2016
@commy2 commy2 added this to the 2.4.1 milestone May 31, 2016
@commy2
Copy link
Contributor Author

commy2 commented May 31, 2016

Example:

        author = "$STR_CBA_Author";
        authors[] = {"Solus","Killswitch","commy2"};

will be displayed as: CBA-Team, Solus, Killswitch, commy2

<German>CBA-Team</German>
</Key>
</Package>
</Project>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 spaces indentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as other .xml files.

<Project name="CBA_A3">
<Package name="Main">
<Key ID="STR_CBA_Author">
<English>CBA-Team</English>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CBA Team (two words, no hyphen)

@commy2 commy2 mentioned this pull request Jun 1, 2016
@commy2 commy2 added the WIP label Jun 1, 2016
@commy2
Copy link
Contributor Author

commy2 commented Jun 1, 2016

I will also change authorURL to prioritize the new url entry

@commy2 commy2 removed the WIP label Jun 1, 2016
@Killswitch00 Killswitch00 merged commit 0fef1ae into master Jun 1, 2016
@commy2 commy2 deleted the handle_author_string_entry branch June 1, 2016 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants