Update fnc_taskPatrol func header

[Wired-Tiger]

I noticed that an error is thrown from fnc_addWaypoint if the position and radius wasn't passed so they would not be optional.

Also, could someone explain to me the point of line 49: private _this += _this;
I've been trying to understand the point of it, but I've removed it and the function works the same with or without it from what I can tell. Is it left over code by chance?

[nicolasbadano]

_this += _this creates a copy of the parameters array, so the final element can be deleted without afecting the original data. This is important because arrays are always passed as reference to functions.

[Wired-Tiger]

@esteldunedain Thank you for the explanation. I think what is throwing me off is the scope of _this. I was thinking that _this was equal to [1,2,3,1,2,3,4] instead of [1,2,4] for every instance after that particular code block.... Looking over this I realized that sqf doesn't have a "+=" command for adding like other languages. Sorry about that.

[Killswitch00]

The position and radius parameters are optional and there is no need to change the function header for that reason. Changing the default radius from 100 to 50 in the example call could be useful for the understanding of the function.

[Wired-Tiger]

I figured out where it is going wrong. If all that is passed to the function is the group then _this = [group]. Even though the params defines the other arguments they don't get passed into _this, and because of it CBA_fnc_addWaypoint throws an error, specifically:

`20:15:34 Error position: <addWaypoint [_position, _radius];

_wayp>
20:15:34 Error 0 elements provided, 3 expected
20:15:34 File x\cba\addons\ai\fnc_addWaypoint.sqf, line 20`

Now, when [group, position] are passed the same thing happens, but no error is thrown because CBA_fnc_addWaypoint defaults the radius to 0 so the group ends up standing in place.

Would it be best to leave the code the way it is and just change the func header as I proposed, or change the code to allow for only passing a group?

[Killswitch00]

The function header represents how the function is supposed to (and AFAIK has, at some point in time) work(ed), so the way forward here is to fix the now broken function.

[Killswitch00]

pushBack (camelCase)