-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JR for APEX #387
JR for APEX #387
Conversation
A3 Apex gives us Retextured Weapons and Attachments from A3 vanilla. These have been added in to current config without requiring APEX as addon. -sTanG
A3 Apex gives us Retextured Weapons and Attachments from A3 vanilla. These have been added in to current config without requiring APEX as addon. -sTanG
Please use 4 spaces for indentation and opening braces on the same line as class. |
@@ -76,6 +77,20 @@ class asdg_OpticRail1913: asdg_OpticRail { // the "medium" rail, long enough to | |||
optic_KHS_hex = 1; | |||
optic_KHS_old = 1; | |||
optic_KHS_tan = 1; | |||
//dpapexaddon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just // Apex
will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 4 spaces for indent does not fit the files current structure as I see it.... and if you guys want to use it please do and make what ever changes you need. If spaces and indents are what you are worried about when a free lance community guys helps update then im helping the wrong people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 4 spaces for indent does not fit the files current structure as I see it
Yes it is. You can check the diff here to see the obvious difference. You must have used an editor that displays it differently.
If spaces and indents are what you are worried about when a free lance community guys helps update then im helping the wrong people.
So you expect anyone can contribute with their own coding style? That would be an incredible mess. Every project needs to have some standard or you are asking for ugly code and a mess.
Additionally, we are free lance community guys as well, we don't get anything by maintaining and developing CBA.
These configs don't look right. Is it changing class inheritance? |
close in favour of #388 |
A3 Apex gives us Retextured Weapons and Attachments from A3 vanilla. These were added to the CfgWeapons and JRClasses, i left Apex as a not required addon :)
-sTanG