Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JR for APEX #387

Closed
wants to merge 2 commits into from
Closed

JR for APEX #387

wants to merge 2 commits into from

Conversation

ravmustang
Copy link

@ravmustang ravmustang commented Jun 19, 2016

A3 Apex gives us Retextured Weapons and Attachments from A3 vanilla. These were added to the CfgWeapons and JRClasses, i left Apex as a not required addon :)
-sTanG

A3 Apex gives us Retextured Weapons and Attachments from A3 vanilla.
These have been added in to current config without requiring APEX as
addon.
-sTanG
A3 Apex gives us Retextured Weapons and Attachments from A3 vanilla.
These have been added in to current config without requiring APEX as
addon.
-sTanG
@jonpas
Copy link
Member

jonpas commented Jun 19, 2016

Please use 4 spaces for indentation and opening braces on the same line as class.

@@ -76,6 +77,20 @@ class asdg_OpticRail1913: asdg_OpticRail { // the "medium" rail, long enough to
optic_KHS_hex = 1;
optic_KHS_old = 1;
optic_KHS_tan = 1;
//dpapexaddon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just // Apex will do.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 4 spaces for indent does not fit the files current structure as I see it.... and if you guys want to use it please do and make what ever changes you need. If spaces and indents are what you are worried about when a free lance community guys helps update then im helping the wrong people.

Copy link
Member

@jonpas jonpas Jun 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 4 spaces for indent does not fit the files current structure as I see it

Yes it is. You can check the diff here to see the obvious difference. You must have used an editor that displays it differently.

If spaces and indents are what you are worried about when a free lance community guys helps update then im helping the wrong people.

So you expect anyone can contribute with their own coding style? That would be an incredible mess. Every project needs to have some standard or you are asking for ugly code and a mess.
Additionally, we are free lance community guys as well, we don't get anything by maintaining and developing CBA.

@commy2
Copy link
Contributor

commy2 commented Jun 19, 2016

These configs don't look right. Is it changing class inheritance?
We shouldn't do these configs just yet anyway. My experience says that BI will change details around many times until the release of APEX.

@commy2 commy2 changed the title Master JR for APEX Jun 19, 2016
@commy2
Copy link
Contributor

commy2 commented Jun 22, 2016

close in favour of #388

@commy2 commy2 closed this Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants