Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fnc_headDir compatible with the 1.54 ports #405

Merged
merged 2 commits into from
Jul 3, 2016

Conversation

Killswitch00
Copy link
Contributor

This makes fnc_headDir load without errors when using the 1.54 MacOS/Linux
ports.

This makes fnc_headDir load without errors when using the 1.54 MacOS/Linux
ports.
ADD(_diff,_unit getDir ([_offset] call CBA_fnc_getPos));
#else
ADD(_diff,[_unit, [_offset] call CBA_fnc_getPos] call BIS_fnc_dirTo);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ARR_x macro?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like ARR_2(_unit,[_offset] call CBA_fnc_getPos) ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... ARR_x, despite what the name suggests doesn't actually create an array for you.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADD(_diff,[ARR_2(_unit, [_offset] call CBA_fnc_getPos)] call BIS_fnc_dirTo);
this is how it must look like ARR_2 must be use because of some issues with the preprocessor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I know. I was just thinking out loud... :-)

@Killswitch00 Killswitch00 merged commit 011e17c into master Jul 3, 2016
@thojkooi thojkooi deleted the headDir-154-bwc branch July 3, 2016 11:18
@commy2 commy2 added this to the 2.4.2 milestone Jul 10, 2016
@commy2 commy2 added the Bug Fix label Jul 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants