AI function fixes and improvements #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,13 +38,12 @@ _position = [_position,_group] select (_position isEqualTo []); | |||
| _position = _position call CBA_fnc_getPos; | |||
|
|
|||
| [_group] call CBA_fnc_clearWaypoints; | |||
| _group enableAttack false; | |||
There was a problem hiding this comment.
Since it's now using _unit disableAI "PATH"; this allows units not assigned to a position to counterattack in the case of contact
There was a problem hiding this comment.
I updated the commit message to more clearly reflect the reasoning
If a building search was enacted, the waypoint would be locked by the searchNearby function before it is actually considered completed. This would result in AI repeatedly going back to the same waypoint and triggering the onCompletion statement causing another building search.
The array of building positions stored by the function would be set to `nil` then subsequently set to an empty array in the event of all positions being used up. This would result in the building never being used again by future calls to the function.
- Minor optimization - Using the new `disableAI "PATH"` simplifies the code and allows it to be easily reverted unlike `doStop` - If patrol is enabled then units should patrol regardless of how many are assigned, otherwise they end up standing around - Units in position are told to stay upright for better use of windows and more engaging combat - No longer need to `enableAttack false` since no longer using `doStop` - which allows unassigned units to counterattack in case of contact
|
merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: