Disable default settings button if setting is already default #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks nice. |
| @@ -98,6 +103,11 @@ for "_index" from 0 to (((count _defaultValue max 3) min 4) - 1) do { | |||
| _color set [_index, _value]; | |||
| _ctrlSettingPreview ctrlSetBackgroundColor _color; | |||
| SET_TEMP_NAMESPACE_VALUE(_setting,_currentValue,_source); | |||
|
|
|||
| //If new setting is same as default value, grey out the default button | |||
| (_control getVariable QGVAR(linkedControls)) params ["", "", "_defaultControl"]; | |||
There was a problem hiding this comment.
OK. IDK why, but it keeps messing up the line of this ^ comment. Meant for L108.
|
Looks good. Suggested minor optimizations. After that can be merged. |
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CBA Settings, this will grey-out (
ctrlEnabled false) the button for default settings if the setting is already set to the default valueI think this will make it easier to find settings that have been changed and easier to get all settings back to default.
Quick demo: https://www.youtube.com/watch?v=A90L1dy9dXE
Also disabled the Import button when in multiplayer as it did not work.