Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only allow logged in admins to change settings #448

Merged
merged 3 commits into from
Aug 6, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jul 30, 2016

When merged this pull request will:

  • This PR makes it so only logged in admins can change server settings as opposed to voted in admins as well.

@commy2 commy2 added the Bug Fix label Jul 30, 2016
@commy2 commy2 added this to the 3.0.1 milestone Jul 30, 2016
@@ -58,8 +58,10 @@
#define MENU_OFFSET_COLOR 1.0
#define MENU_OFFSET_COLOR_NEG -0.7

#define IS_ADMIN serverCommandAvailable "#shutdown"
Copy link
Contributor

@Dorbedo Dorbedo Jul 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe put a version of this macro in "script_macros_common.hpp"?
could be useful elsewhere

@Killswitch00
Copy link
Contributor

So, any macro addition as suggested by Dorbedo?

@commy2
Copy link
Contributor Author

commy2 commented Aug 6, 2016

done
IS_ADMIN and IS_ADMIN_LOGGED

@thojkooi
Copy link
Contributor

thojkooi commented Aug 6, 2016

Build failure is not related to this PR.

@Killswitch00 Killswitch00 merged commit f0c2ac8 into master Aug 6, 2016
@Killswitch00 Killswitch00 deleted the settings-only-logged-admins branch August 6, 2016 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants