remove non functional marker persistency from network component

[commy2]

When merged this pull request will:

• CBA_fnc_set/add/remove/getMarkerPersistent do nothing in Arma 3. All global markers are always persistent
• No one uses these functions, so we should just nuke them.

[jonpas]

💥

[Killswitch00]

Ideally, we'd have a "stop using this function, it will be removed soon" helper macro similar to DEPRECATE. How did you determine that "no one uses these functions"?

[commy2]

How did you determine that "no one uses these functions"?

All I did was a google search. At least no open source project is using it. All I could find is A2 scripts from 2010.
I really doubt that any closed project uses it either. The function never did anything in Arma 3. There was a need for this back in A2, but not anymore.

I could make DEPRECATED functions for these (at least for set and get, add and remove where already deprectaed years ago.) But all that would do is write an error message into the RPT, nothing else.
If someone actually uses these functions and we remove them, all that would happen is that a "undefined variable used" error is logged. So essentially the same thing as if we properly deprecate them.
I somehow feel that making a function just to exchange one error for another is not worth it.

[Killswitch00]

Ok, let's ditch them.

[shadez95]

CBA_A3/addons/common/fnc_createMarker.sqf

Line 62 in 64034f5

if (_persist) then { [_m, true] call CBA_fnc_setMarkerPersistent };

Above is still using CBA_fnc_setMarkerPersistent