Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'CBA_fnc_peak' #476

Closed
wants to merge 1 commit into from
Closed

fix 'CBA_fnc_peak' #476

wants to merge 1 commit into from

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Aug 21, 2016

When merged this pull request will:

  • call compile _varName replaced with missionNamespace getVariable _varName
  • reduce network traffic by using the new CBA_fnc_serverEvent and CBA_fnc_ownerEvent instead of CBA_fnc_globalEvent twice
  • fix example was wrong (cba_diagnostics_receive_peak has a S too much)
  • fix CBA_fnc_peek is broken (undefined GVAR instead of QGVAR):
18:52:49 Error in expression <nostic\peek';
params ["_variable"];



[cba_diagnostic_peek, _variable] call CBA>
18:52:49   Error position: <cba_diagnostic_peek, _variable] call CBA>
18:52:49   Error Undefined variable in expression: cba_diagnostic_peek
18:52:49 File x\cba\addons\diagnostic\fnc_peek.sqf, line 9
  • formating

Since the function was broken anyway and actually never worked, we might as well fix the spelling and rename it to CBA_fnc_peak instead of CBA_fnc_peek

@commy2 commy2 added this to the 3.0.1 milestone Aug 21, 2016
@commy2
Copy link
Contributor Author

commy2 commented Aug 21, 2016

Alternatively, we just remove this. It doesn't actually seem all that usefull.

@PabstMirror
Copy link
Contributor

peek was the right spelling

@commy2
Copy link
Contributor Author

commy2 commented Aug 21, 2016

{
description = "Peek at variable on the server To receive the variable content back, you will have to [""cba_diagnostics_receive_peak"", {_this call myFunction}] call CBA_fnc_addEventHandler;";
file = "\x\cba\addons\diagnostic\fnc_peek.sqf";
description = "Peak at variable on the server To receive the variable content back, you will have to [""cba_diagnostic_receivePeak"", {_this call myFunction}] call CBA_fnc_addEventHandler;";
Copy link
Member

@jonpas jonpas Aug 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server To receive

Probably missing a point? I'd also get rid of the usage code from this description, it has no place to be here, but in function header.

@PabstMirror
Copy link
Contributor

If it's been broken for a long time that probably means no one is using it, could just remove.

@commy2
Copy link
Contributor Author

commy2 commented Aug 21, 2016

According to github, it never worked. At least not since 2009.

@Killswitch00
Copy link
Contributor

Peek, not peak, as mentioned.

@Killswitch00
Copy link
Contributor

Function removed, since it's been broken for so long.

@Killswitch00 Killswitch00 deleted the fix-peak branch August 22, 2016 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants