-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 'CBA_fnc_peak' #476
fix 'CBA_fnc_peak' #476
Conversation
Alternatively, we just remove this. It doesn't actually seem all that usefull. |
Ok. But then it was misspelled here: https://github.com/CBATeam/CBA_A3/blob/master/addons/diagnostic/XEH_preInit.sqf#L16 |
{ | ||
description = "Peek at variable on the server To receive the variable content back, you will have to [""cba_diagnostics_receive_peak"", {_this call myFunction}] call CBA_fnc_addEventHandler;"; | ||
file = "\x\cba\addons\diagnostic\fnc_peek.sqf"; | ||
description = "Peak at variable on the server To receive the variable content back, you will have to [""cba_diagnostic_receivePeak"", {_this call myFunction}] call CBA_fnc_addEventHandler;"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
server To receive
Probably missing a point? I'd also get rid of the usage code from this description, it has no place to be here, but in function header.
If it's been broken for a long time that probably means no one is using it, could just remove. |
According to github, it never worked. At least not since 2009. |
Peek, not peak, as mentioned. |
Function removed, since it's been broken for so long. |
When merged this pull request will:
call compile _varName
replaced withmissionNamespace getVariable _varName
CBA_fnc_serverEvent
andCBA_fnc_ownerEvent
instead ofCBA_fnc_globalEvent
twicecba_diagnostics_receive_peak
has a S too much)CBA_fnc_peek
is broken (undefinedGVAR
instead ofQGVAR
):Since the function was broken anyway and actually never worked, we might as well fix the spelling and rename it to
CBA_fnc_peak
instead ofCBA_fnc_peek