Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update function header 'CBA_fnc_debug' #498

Merged
merged 2 commits into from
Sep 9, 2016
Merged

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Sep 6, 2016

When merged this pull request will:

  • rewrites CBA_fnc_debug to simplify using new commands ... and make it less confusing in general.
  • update function header of CBA_fnc_debug (description of some optional parameters was wrong / misleading)
  • Doesn't display (formatted) time and tickTime, but only the formatted CBA_missionTime. I think two of them is just confusing and CBA_missionTime is more "accurate" than time
  • I don't know where numbers like 178 and 180 come from, but that doesn't seem to be the line limit in RPTs anymore. Messages are continued on the next line anyway. It's also impossible to predict the line length in Arma 3, because it now automatically adds the machine time stamp.

I went with 120 for chat and RPT, because I felt like that was reasonably readable. Could be changed to something else though, idk.

It's a bit ugly at L85ff, but that is to only way to fix this current bug:
The message will not be displayed when it's shown before the loading screen disappears. This is because Arma resets the chat control after that. This happens mainly during JIP for only the connecting player, but can also happen in SP, depending on when CBA_fnc_debug was executed and if the briefing is enabled. Doing it this way, with uiSleep will make it still show up during the MP briefing.
The player would not see the debug messages in these cases.

I no longer use CREATELOGICLOCAL but GVAR(logic) = "Logic" createVehicleLocal [0,0,0]; , because the macro would result in the variable name ADDON (CBA_network), which collides with the flags we use in preInit (ADDON = false/true;) to indicate that an addon was loaded (correctly)

@commy2 commy2 added this to the 3.1 milestone Sep 6, 2016
@commy2 commy2 added the Bug Fix label Sep 6, 2016
@commy2 commy2 modified the milestones: 3.2, 3.1 Sep 6, 2016
@Killswitch00 Killswitch00 merged commit ffd5fa7 into master Sep 9, 2016
@Killswitch00 Killswitch00 deleted the improve-debug-function branch September 9, 2016 16:37
@commy2 commy2 modified the milestones: 3.1, 3.2 Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants