fix default value of 'CBA_fnc_hashHasKey', close #502 #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
reviewed
Sep 17, 2016
| @@ -23,6 +23,6 @@ Author: | |||
| SCRIPT(hashHasKey); | |||
|
|
|||
| // ----------------------------------------------------------------------------- | |||
| params [["_hash", [], [[]]], "_key"]; | |||
| params [["_hash", [] call CBA_fnc_hashCreate, [[]]], "_key"]; | |||
There was a problem hiding this comment.
The array is fully evaluated first, so CBA_fnc_hashCreate function would be called every time,
even on good input.
Could just use [[], []] which will be good enough for this function (_hash select 1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
(_hash select 1)will error out.