Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove obsolete team synch code #511

Merged
merged 2 commits into from
Sep 24, 2016
Merged

remove obsolete team synch code #511

merged 2 commits into from
Sep 24, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Sep 23, 2016

When merged this pull request will:

  • removes team synch code
  • no longer needed as teams are synched since 1.62
  • old versions are no longer supported by 3.1.0, because of changes in class inheritance for the JR component

@commy2 commy2 added this to the 3.1 milestone Sep 23, 2016
@PabstMirror
Copy link
Contributor

ace still uses the event
https://github.com/acemod/ACE3/blob/master/addons/interaction/functions/fnc_joinTeam.sqf#L21

@commy2
Copy link
Contributor Author

commy2 commented Sep 23, 2016

But does it do anything?

@PabstMirror
Copy link
Contributor

PabstMirror commented Sep 23, 2016 •
edited
Loading

We call the cba event to change fireteams, should probably just make our own
Edit, but this shouldn't go in 3.1

@jonpas
Copy link
Member

jonpas commented Sep 23, 2016

Other people might be using the event as well.

@commy2
Copy link
Contributor Author

commy2 commented Sep 23, 2016

^ this should solve it

@commy2 commy2 merged commit 54ef2da into master Sep 24, 2016
@commy2 commy2 deleted the remove-team-synch branch September 24, 2016 04:29
@jonpas jonpas mentioned this pull request Aug 15, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@commy2 @PabstMirror @jonpas