Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MRT Accessory Functions #513 #555

Merged
merged 8 commits into from
Jan 4, 2017
Merged

Add MRT Accessory Functions #513 #555

merged 8 commits into from
Jan 4, 2017

Conversation

robalo
Copy link
Contributor

@robalo robalo commented Nov 27, 2016

When merged this pull request will:

@jonpas
Copy link
Member

jonpas commented Nov 28, 2016

I feel like this could use a better component name.

@robalo
Copy link
Contributor Author

robalo commented Nov 28, 2016

@jonpas me too, feel free to suggest a better name for it

@commy2
Copy link
Contributor

commy2 commented Nov 28, 2016

should use:

private _unit = call CBA_fnc_currentUnit;

and then _unit instead of player, so it works when remote controlling units with Zeus.

@Killswitch00
Copy link
Contributor

Yeah, about that "accfcns" name.... How about just "accessory" (1 char longer, but more readable)?

@robalo
Copy link
Contributor Author

robalo commented Dec 27, 2016

I like it.

Copy link
Contributor

@Killswitch00 Killswitch00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Killswitch00 Killswitch00 merged commit 0d4f10d into master Jan 4, 2017
@Killswitch00 Killswitch00 deleted the mrt_accfnc_new branch January 4, 2017 18:24
@commy2 commy2 added this to the 3.2 milestone Jan 7, 2017
@commy2 commy2 added the Feature label Jan 7, 2017
@commy2 commy2 mentioned this pull request Mar 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants