Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task modules #571

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Fix task modules #571

merged 1 commit into from
Jan 4, 2017

Conversation

kymckay
Copy link
Contributor

@kymckay kymckay commented Dec 24, 2016

  • isGlobal = 2 is persistent execution which is totally unnecessary for these
  • RscDisplayCurator was set to nonexistent display which would cause errors if somehow clicked on by a curator
  • default is a boolean property used to set which value of a selection is the default
  • No need to define selection for boolean arguments (they can only be true or false)
  • Some optimization

- isGlobal = 2 is persistent execution which is totally unnecessary for these
- RscDisplayCurator was set to nonexistent display which would cause errors if somehow clicked on by a curator
- `default` is a boolean property used to set which value of a selection is the default
- No need to define selection for boolean arguments (they can only be true or false)
- Some optimization
@Killswitch00 Killswitch00 merged commit 908bc93 into CBATeam:master Jan 4, 2017
@kymckay kymckay deleted the fixModules branch January 5, 2017 15:53
@commy2 commy2 added the Bug Fix label Jan 7, 2017
@commy2 commy2 added this to the 3.2 milestone Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants