Enhance patrol pattern of taskPatrol #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix potential for error if input params are nil - Fix weird bug where calling from unit init in editor places all waypoints on one spot - Place waypoints on a semi-random pattern to produce patrols that cover the whole radius and make more sense
commy2
reviewed
Dec 24, 2016
| @@ -46,25 +51,30 @@ _position = _position call CBA_fnc_getPos; | |||
| // Clear existing waypoints first | |||
| [_group] call CBA_fnc_clearWaypoints; | |||
|
|
|||
| // Can pass paremeters straight through to addWaypoint | |||
| private _this =+ _this; | |||
There was a problem hiding this comment.
Something else.
_this =+ _this.
Or assign a new variable. Scope of _this already is set, so there is no point in that private.
There was a problem hiding this comment.
Ah wasn't sure about this one 👍
|
Not much of a christmas person either, huh? |
|
😆 More that it's one of the few times of year I have a lot of free time and everywhere is super busy. Excluding the actual 25th it's all coding and gym for me 💪 |
Cuel
reviewed
Dec 25, 2016
| private _rad = _radius*random [0.1, 0.75, 1]; | ||
|
|
||
| // Alternate sides of circle & modulate offset | ||
| private _theta = (_i%2)*180 + sin(deg(_step*_i))*_offset + _step*_i; |
There was a problem hiding this comment.
No specific reason, this is just how I tend to write calculations (probably because I'm used to seeing algebraic expressions all the time in engineering)
| case 2 : {_this pushBack _radius}; | ||
| default {}; | ||
| }; | ||
| // Can pass paremeters straight through to addWaypoint |
Killswitch00
approved these changes
Dec 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the whole radius and make more sense