Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RETNIL and RETDEF throwing script errors in scheduled environment #576

Merged
merged 4 commits into from
Jan 13, 2017

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jan 10, 2017

When merged this pull request will:

execVM "\x\cba\addons\common\test_ret.sqf"

@commy2 commy2 added the Bug Fix label Jan 10, 2017
@commy2 commy2 added this to the 3.2 milestone Jan 10, 2017
@commy2 commy2 self-assigned this Jan 10, 2017
@Dorbedo
Copy link
Contributor

Dorbedo commented Jan 11, 2017

Aren't the macros part of the main component?
If not, maybe the test_macro_is_x.sqf should be moved to common too.

@commy2
Copy link
Contributor Author

commy2 commented Jan 11, 2017

The problem is that the ruby script is set up in a way were test_x is not included. The test.sqf in main is only a hub to call the other test functions. test_macro_is_x.sqf is never used atm.
Tbh, I think it is easier to just execVM the individual tests, since params throws errors now and a bunch of other tests fail every time (sometimes due to a lacking player when tested in the 2d editor).

@commy2
Copy link
Contributor Author

commy2 commented Jan 11, 2017

There. Moved. No guarantee that the test still works though.

@commy2 commy2 merged commit f62a6f9 into master Jan 13, 2017
@commy2 commy2 deleted the fix-retdef-retnil-scheduled branch January 13, 2017 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RETNIL and RETDEF throwing script errors
3 participants