pass short functions to addXEventHandler to reduce compile times #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Killswitch00
approved these changes
Feb 13, 2017
|
For reference: https://feedback.bistudio.com/T123355 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
addXEventHandlerare stored internally as strings and have to be compiled every time the event handler is executed.callcommand, so it's worth to replace them with short{call <FUNCTION>}functions._this call, because the unary syntax ofcalldoesn't overwrite_thisanyway, so it's the same result, but even faster while only being slightly less readable (arguably).