Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "unit" changed PlayerEH not working reliably #617

Merged
merged 2 commits into from
Mar 16, 2017
Merged

Fix "unit" changed PlayerEH not working reliably #617

merged 2 commits into from
Mar 16, 2017

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Mar 10, 2017

When merged this pull request will:

  • "unit" and "vehicle" player eventhandlers seem to not work the same as the BI playerViewChanged after all, so switch back to the old polling method to avoid bugs.

@commy2 commy2 added the Bug Fix label Mar 10, 2017
@commy2 commy2 added this to the 3.3 milestone Mar 10, 2017
@commy2 commy2 self-assigned this Mar 10, 2017
@commy2 commy2 changed the title revert playerChanged eh to use old method, fix #615 Fix "unit" changed PlayerEH not working reliably Mar 10, 2017
@PabstMirror
Copy link
Contributor

Can confirm this is needed. "unit" is giving problems with selectPlayer on dedicated

@commy2 commy2 merged commit 2f37af3 into master Mar 16, 2017
@commy2 commy2 deleted the fix-playerChanged branch March 16, 2017 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Killswitch00 Killswitch00 Killswitch00 approved these changes

Assignees

@commy2 commy2

Labels
Bug Fix
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@commy2 @PabstMirror @Killswitch00