-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve performance of namespace #619
Conversation
Going to be in ACRE 2.4.1. |
Would |
80 -> 77, so yeah, it helps a lot. Not usable for local namespaces though, since simple objects are always transferred over network. Also only possible since this version:
|
Had to also adjust |
|
When merged this pull request will:
After 1.68 update, the performance cost of rendering local CBA namespaces is higher if they are
drawType = "name";
than they are withdrawType = "area";
, so we can change this to have a very slight performance boost with the map opened (becomes apparent with very large number of namespaces).Map - FPS no local namespaces: 62-65 FPS
Map - 50k local namespaces before this PR: 14-15 FPS
Map - 50k local namespaces after this PR: 50 FPS
Additionally I now
disable the simulation of the global namespaces viause simple objects for the global namespaces. (possible since they are OBJECT and not LOCATION).init
eventhandler72-75 FPS (65 on map)59 FPS (same on map)Local namespaces are drawn (LOCATION) while the map is opened, while global namespaces are always simulated (OBJECT). This explains why local namespaces have (almost) no effect on FPS when the map is closed, while they have a bigger one if the map is shown.
Additionally, ACRE is using
setText
on the local namespace for no apparent reason. I suggest that they stop doing that, since that cuts the FPS in half with 50k local namespaces (14->7 before this PR, 50->24 after this PR).