Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and simplify the help component ui #629

Merged
merged 1 commit into from
Apr 8, 2017
Merged

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Apr 7, 2017

When merged this pull request will:
config:

  • simplified the ui configs (deleting superfluous, inherited, not working etc. entries)
  • removed unused macro defines and adjusted macro names
  • fixed grid / positioning

scripts:

  • replaced DisplayLoad eventhandlers with newish onLoad control eventhandlers
  • removed disableSerialization (does nothing in unscheduled script)
  • increased time one version line is shown from 3 to 4 seconds
  • simplified some argument passing

fixed:

  • color in credits line not working as intended (beige was using white)
  • shadow in credits line not disabled like intended
  • vertical align not working (work around by moving control instead)
  • text size not working as intended (I think?)
  • overlapping version line in main menu

changed:

  • font to match other fonts used near our controls
  • only display author and not also authors, so the credits line doesn't become too long and overlaps.

Very large ui before:
http://i.imgur.com/9DjWdjm.png

Very large ui after:
http://i.imgur.com/kgbYfCS.png

Also adjusted font and positioning ingame:
http://i.imgur.com/nMcVQzj.png

@Killswitch00 Killswitch00 merged commit 542490d into master Apr 8, 2017
@commy2 commy2 added this to the 3.3 milestone Apr 8, 2017
@commy2 commy2 deleted the cleanup-help branch April 8, 2017 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants