remake keybinding ui and add mouse support #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[
"Test Category",
"Test",
["key action name", "key action tooltip"],
{systemChat str 1},
{systemChat str 2},
[15, [false, false, false]]
] call cba_fnc_addKeybind; |
commy2
force-pushed
the
improve-keybinding-ui
branch
from
f57b534
to
5952b77
Compare
commy2
changed the title
|
note:
|
addons/keybinding/fnc_addKeybind.sqf
Outdated
| // data for controls menu | ||
| if (isNil QGVAR(actions)) then { | ||
| GVAR(actions) = [] call CBA_fnc_createNamespace; | ||
| //GVAR(keys) = [] call CBA_fnc_createNamespace; |
There was a problem hiding this comment.
Yeah, it's all still experimental and wip.
|
Part of this went into #656, so this PR can eventually only change the gui and not |
commy2
force-pushed
the
improve-keybinding-ui
branch
from
5952b77
to
8b5a0fb
Compare
|
done |
|
ACE uses -1 for some unbound keys throws |
PabstMirror
reviewed
May 9, 2017
| @@ -92,6 +92,8 @@ if (_defaultKeybind isEqualTypeParams [0, false, false, false]) then { | |||
| _defaultKeybind params [["_defaultKey", 0, [0]], ["_defaultModifiers", [], [[]]]]; | |||
| _defaultModifiers params [["_defaultShift", false, [false]], ["_defaultControl", false, [false]], ["_defaultAlt", false, [false]]]; | |||
|
|
|||
| _defaultKey = _defaultKey max 0; | |||
There was a problem hiding this comment.
What about big numbers?
min 254?
There was a problem hiding this comment.
Why would anyone use these?
commy2
commented
May 10, 2017
| [0xF8, 0x100004], // Mouse wheel up | ||
| [0xF9, 0x100005], // Mouse wheel down | ||
| [84, DIK_SYSRQ], | ||
| [198, DIK_PAUSE] |
There was a problem hiding this comment.
Alt+Print and Ctrl+Pause leads to UNEXPECTED_KEY, even in vanilla, but this makes them display the right key.
commy2
force-pushed
the
improve-keybinding-ui
branch
2 times, most recently
from
9b6dc1a
to
c48c26d
Compare
commy2
changed the base branch from
localizeKey
to
keybinding-cfgFunctions-macros
commy2
force-pushed
the
improve-keybinding-ui
branch
from
1a075ff
to
9545ccb
Compare
remember last selected addon in keybinding ui
Killswitch00
approved these changes
May 17, 2017
commy2
added a commit
that referenced
this pull request
May 20, 2017
* Mouse support for CBA_fnc_addKeyHandler (#651) * use last possible single key as array size * delete superfluous check, fix header * roll less, but bigger numbers to generate random hashkey * header formatting * only compile functions on machines with interface * add mission display ui events directly on display init * rename display load functions for naming conventions * prepare mouse handers in zeus display * fix issues with blocking key events * isEqualTo for maximum performance :S * fix no return value making blocking undefined * simplify * better variable name * remove a superfluous check * add a comment to seperate key handler code from other stuff * add support for mouse keys and the scroll wheel * add mouse button translations (#652) * add mouse button translations to custom dik codes * fix keyHandler becoming unremovable if added to two different keys (#653) * fix keyHandler becoming unremovable if added two different keys * fix strange modifier key behavior (#654) * fix strange modifier key behaviour * disable modifier state in keyDown if released * squash-CBA_fnc_addKeybind-redo (#656) * fix a script error * add function to translate keys * joinString * fix rebinding would delete default keyup handler * CfgFunctions * display multiple keybinds in diary * fix for travis * remake keybinding ui and add mouse support (#638) * remake rebinding ui for mouse support * remember last selected addon in keybinding ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Also has all the features the vanilla keybinding ui has. Undo, Delete, Default, Next, Prev and they all do exactly the same.