Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix assignment operator return value bug for directCall #665

Merged
merged 1 commit into from
May 4, 2017
Merged

fix assignment operator return value bug for directCall #665

merged 1 commit into from
May 4, 2017

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented May 4, 2017

When merged this pull request will:

  • title

before PR:

_a = {_b = 1} call CBA_fnc_directCall; // generic error
isNil "_a"

after PR:

_a = {_b = 1} call CBA_fnc_directCall;
isNil "_a"
-> true

@commy2 commy2 added the Bug Fix label May 4, 2017
PabstMirror
PabstMirror reviewed May 4, 2017
View reviewed changes
addons/common/fnc_directCall.sqf

private "_CBA_return";

isNil {
_CBA_return = _CBA_arguments call _CBA_code;
_CBA_return = [_x] apply _CBA_code select 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of _x?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So _x doesn't become undefined in _CBA_code, but stays _x.

@Killswitch00 Killswitch00 merged commit e920c0c into master May 4, 2017
@Killswitch00 Killswitch00 deleted the fix-generic-error branch May 4, 2017 16:29
@commy2 commy2 added this to the 3.4 milestone May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror left review comments

Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@commy2 @PabstMirror @Killswitch00