Optimize CBA_fnc_players

[kymckay]

When merged this pull request will:

• Use allDeadMen instead of allDead

allDead includes destroyed vehicles.

[commy2]

#353 (comment)

But I never reproduced this. Will try right now.

[PabstMirror]

NOTE: In player hosted game, the complete array of allPlayers may get delayed at the start. Use BIS_fnc_listPlayers if you need it earlier

Edit: Also see acemod/ACEX#25
Could possibly do if (CBA_missionTime < 200) then {oldWay} else {allPlayers}; but I'm not sure what the cut off is, and might not work for player's jipping.

[commy2]

addMissionEventHandler ["EachFrame", {
    diag_log [diag_frameNo, allPlayers, [] call CBA_fnc_players, allPlayers isEqualTo ([] call CBA_fnc_players)];
}];

 0:39:07 [11821,[B CSCustom0:1 (Gefr. commy2)],[B CSCustom0:1 (Gefr. commy2),B CSCustom0:2 (Gefr. commy2 (2)) REMOTE],false]

[commy2]

But why does it use allDead and not allDeadMen?

allDead
Return a list of all dead units including agents and destroyed vehicles. Dead units may be in vehicles.

[kymckay]

Is it confirmed that the old way truly does return all players under the same circumstances in which allPlayers doesn't?

[commy2]

See my test. Was local hosted.

[kymckay]

Ah yeah, missed that 👍 Can change this to simply switch to allDeadMen then

[commy2]

It's still an optimization, because isPlayer filters out the wrecks atm. But this makes it slightly faster by not listing them in the first place.