Always re-run preInit on mission load/new

[PabstMirror]

Should fix #684

Seems like in 1.70, missionnamespace alwayse gets cleared out
(which seems good, just causes some problems)

[PabstMirror]

Going from one terrain to another

"OnMissionNew"
XEH: missionNamespace processed [false]
[83008,343.676,0,"XEH: PreInit started. v3.3.1.170504"]
[83008,344.812,0,"XEH: PreInit finished."]
"OnTerrainNew"
XEH: missionNamespace processed [false]
83008,346.107,0,"XEH: PreInit started. v3.3.1.170504"]

both events happen on the same frame, but missionNamespace is wiped between them
OnTerrainNew seems to be last, so if we don't add the event, nothing will be defined

[commy2]

OnTerrainNew is still needed as it fires after OnMissionLoad and the missionNamespace get's wiped inbetween them for whatever reason.

[PabstMirror]

• Major problem is this doesn't work when loading of a mission fails.
  e.g. You load a mission that has requiredAddons you aren't running.
  Mission namespace gets wiped, but no onMissionLoad event.

• Minor problem, we run preInit more than we have to, worst case seems to be going from one map to loading a mission on another map, preInit runs 3 times:

"OnMissionNew"
XEH: missionNamespace processed [false]
"OnTerrainNew"
XEH: missionNamespace processed [false]
"OnMissionLoad"
XEH: missionNamespace processed [false]

[commy2]

To the 2nd point, doesn't really matter imo. preInit is mainly copying over stuff from ui namespace via PREP.

1st one. Why would loading a mission fail?

[PabstMirror]

Warning Message: mission.sqm/Mission/Entities/Item2/Entities/Item0.type: Vehicle class CUP_O_TK_Crew no longer exists

[commy2]

And that opens an empty mission on the same map as selected, right?

[PabstMirror]

yea

[commy2]

I don't like how convoluted this has become. All 3 events are needed, but they all fire, because BI keeps wiping the namespace.

[PabstMirror]

This would catch the mission load failed problem, could possibly replace all other events?

params ["_display"];
private _fnc_watchDog = {
    if (!ISPROCESSED(missionNamespace)) then {
        [] call CBA_fnc_preInit;
    };
};
_display displayAddEventHandler ["MouseMoving", _fnc_watchDog];
_display displayAddEventHandler ["MouseHolding", _fnc_watchDog];

[commy2]

Yeah, I like this more.

[PabstMirror]

This also fixes the multiple running of preInit

[commy2]

ISPROCESSED(missionNamespace) is always false, because that is the condition of the if.

[commy2]

Works and fixes #684.