addKeybind - Handle empty strings to indicated no code

[PabstMirror]

_downCode - Code for down event, empty string for no code. <CODE>

ACRE uses this:
["ACRE2", "CycleRadio", (localize LSTRING(CycleRadio)), { [1] call FUNC(cycleRadios) }, "", [58, [true, false, true]]] call cba_fnc_addKeybind;

[jonpas]

Shouldn't this automatically be done by params? As it only accepts code {} as input, if it's not code it will use the default value, which is code {} anyways.

[commy2]

Why not go the extra mile and do:

+if (_downCode isEqualType "") then {
    _downCode = compile _downCode;
};
 +if (_upCode isEqualType "") then {
    _upCode = compile _upCode;
};

Would make more sense to me.

[PabstMirror]

The new method is consistent with the old way which only checked if it was a string

    if(IS_CODE(_downCode)) then {
        [_hashDown, "keydown"] call cba_fnc_removeKeyHandler;

Compiling could cause problems if they pass something like "#nothing".
I figured it's deprecated anyway as there is no reason to not pass {}

[commy2]

I know what you mean, but then this isn't limited to STRING either, but any type.
And "#nothing" is a bad example, because that actually doesn't throw an error when compiling or calling the result, because # is treated like #LINE 1 and other instructions that survive preprocessing even though it does nothing.

[commy2]

@jonpas True, but it also throws an error. From what I understand, STRING used to work as replacement for CODE just like how you can use STRING inside addEventHandler.

[jonpas]

Ah, you are correct indeed, totally forgot about the error.

[Killswitch00]

The lines below results in any string, empty or not, to be regarded as an empty code block The comment suggests otherwise.