Fix settings menu slow loading #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I totally floundered my way through adjusting the code here, but the settings menu does seem to succesfully load into an initial category and it's quick to load on the ace settings conversion branch. Side effect is that there are a load of duplicate categories listed now.
|
Thanks! Will take a look later. |
|
This looks good to me. I don't know if I should pity you for having to go through my mess or if I should be proud of myself that you found a solution that only changes a small number of lines. |
6 tasks
commy2
approved these changes
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
To be honest I totally fumbled my way through the code until I found the parts that created the controls and handled category changing, then just adjusted those to try and implement the desired behaviour. It appears to work, but I can't say for certain whether there are any undesired side effects of this change that I've overlooked so please review thoroughly.